search

thewca / wca-registration

Registration microservice for the WCA website. Currently being rolled out
GNU General Public License v3.0
6 stars 4 forks source link

Reimplment >= competitor limit check #673

Closed dunkOnIT closed 2 weeks ago

dunkOnIT commented 2 months ago

Previous version of this PR was reverted, as it triggered an error in live environments where Redis only returns strings

FinnIckler commented 2 months ago

https://github.com/thewca/wca-registration/blob/3f7c7e8fc42491d6e45e0affef1cf591fae9a656/app/controllers/registration_controller.rb#L31 Here I just use .to_i not sure what is better

FinnIckler commented 2 months ago

Anyway how you implement it, you should remove the to_i from my line

FinnIckler commented 1 month ago

@dunkOnIT please fix the conflicts and remove the to_i where Registration.accepted_competitors_count(competition_id) is called elsewhere