search

thewca / wca-regulations

Regulations and Guidelines for the World Cube Association.
https://www.worldcubeassociation.org/regulations/
113 stars 64 forks source link

Compile merged Regulations and Guidelines #1200

Closed Nanush7 closed 4 months ago

Nanush7 commented 4 months ago

Add html with the merged flag.

The new option generates a full.html.erb file in the output dir. So now we have three html files, two for the separated documents and one for the merged version.

See https://github.com/thewca/worldcubeassociation.org/pull/9541 and https://github.com/thewca/wca-regulations-compiler/pull/28.

lgarron commented 4 months ago

The new option generates a full.html.erb file in the output dir. So now we have three html files, two for the separated documents and one for the merged version.

I didn't catch that name until now — do you think it would be easy to switch to merged.html.erb?

I think "full" implies that either of the merged documents is "partial", which isn't really accurate.

gregorbg commented 4 months ago

I didn't catch that name until now — do you think it would be easy to switch to merged.html.erb?

I think "full" implies that either of the merged documents is "partial", which isn't really accurate.

Switching the name requires an update to the Python WRC-compiler, which is easy enough. It won't require another code change in this repository, just a new trigger of the GH Action with the updated wrc version.