We don't handle corrupt zip files very well

thewca / wca-workbook-assistant

Java application for processing Excel workbooks with WCA competition results for uploading them to the WCA database

7 stars 4 forks source link

We don't handle corrupt zip files very well #110

Closed jfly closed 8 years ago

jfly commented 8 years ago

(I thought we already had an issue for this, but I could not find it. @jazzthief81, was there an issue for this already?)

Arash just ran into this issue. I'm pretty sure something bad happened while downloading the database export, and then he ended up in a state where the workbook assistant would barf while trying to parse the downloaded zip file, but not display any terribly obvious errors to him: https://groups.google.com/d/msg/wca-software/duXwRE8Opp0/dIKNm84wBwAJ.

jazzthief81 commented 8 years ago

@jfly Work has already been done, see https://github.com/cubing/wca-workbook-assistant/issues/94

jfly commented 8 years ago

Ah, nevermind! The behavior when no export is downloaded is a bit weird, but there is a nice red message on the bottom of the window. Closing this issue.