thewca / wca-workbook-assistant

Java application for processing Excel workbooks with WCA competition results for uploading them to the WCA database
7 stars 4 forks source link

Bug importing countries (id vs. name) #112

Closed Luis-J-Ianez closed 8 years ago

Luis-J-Ianez commented 8 years ago

The JSON file is created with countries.name, while WA seems to be expecting countries.id. This is a problem for "Cote d'Ivoire" and "Cote d_Ivoire".

jfly commented 8 years ago

The JSON file is created with countries.name

Are you sure about this, @Luis-J-Ianez? The [WCA Competition JSON Format]() clearly says this about countryId: "Country codes must follow ISO 3166-1-alpha-2 codes".

Looking at the JSON for a few competitions I've been involved in, it looks like ISO2 codes indeed are generated by the WA. Code inspection also tells me that WA generates ISO2 codes. Please see here.

It's hard for me to know exactly what happened without the relevant Excel file from cubecomps, but here's my take on this. Please correct me if I'm wrong:

I'm going to optimisitically close this issue, but please reopen if my understanding is flawed.

Luis-J-Ianez commented 8 years ago

Definitely, I must wait for the coffee of the morning to make effect before starting to reply emails. :P Of course, this is a Cubecomps bug! I'll fix it ASAP.

Luis-J-Ianez commented 8 years ago

For your information, this is fixed in Cubecomps.