search

thewca / wca-workbook-assistant

Java application for processing Excel workbooks with WCA competition results for uploading them to the WCA database
7 stars 4 forks source link

Remove latitude, longitude and zoom from Country #115

Closed jonatanklosko closed 6 years ago

jonatanklosko commented 8 years ago

Fixes #114. I haven't been contributing here before but I hope I've done things right. These are all the places using longitude, latitude and zoom related to Country.

viroulep commented 8 years ago

I checked it out, and I've no more registrations errors on countries :)

Do you have any idea on how to package a release for this? (I don't, I would guess just bump the version here and upload the jar :p)

jonatanklosko commented 8 years ago

@viroulep unfortunately I don't know how to do release stuff.

viroulep commented 8 years ago

Ok plan B then. The PR LGTM as it fixes what should be fixed; I'll send the jar to the results team just for a sanity check, and I'll make a release with it if they validate it!

SAuroux commented 8 years ago

Hi Philippe, please put this on hold. We might have another easy fix which does not require a new WA release.

viroulep commented 8 years ago

Cool :)

jfly commented 6 years ago

Closing this as we were able to work around this without updating the WA.

jfly commented 6 years ago

Actually, let's merge this up so we can get rid of the hack introduced in https://github.com/thewca/worldcubeassociation.org/pull/808.