search

thewca / wca-workbook-assistant

Java application for processing Excel workbooks with WCA competition results for uploading them to the WCA database
7 stars 4 forks source link

Adding scrambles using drag and drop #76

Closed jazzthief81 closed 10 years ago

jazzthief81 commented 10 years ago

Currently Excel workbooks can be opened in the Workbook Assistant by selecting the file from any application (desktop, file explorer, mail client) and dragging and dropping it on the main window of the application. It would be nice of the use were able to add scramble files in the same way. Using the file name extension of the file that was dropped on the window, the application should be able to know the difference between an Excel workbook and a TNoodle file.

jfly commented 10 years ago

This sounds nice. Right now, when you drop an excel file on, the old excel file is tossed. What should happen when you drop new scrambles? Should the old scrambles be tossed? What if you have scrambles, but a new excel file is dropped?

jazzthief81 commented 10 years ago

As suggested in issue #79, I would like the scrambles to be added to the list of scrambles when the user drags and drops the scramble file.

When a new workbook file is opened, I would leave the scrambles as they were and let the user remove and/or add scrambles if required.

jfly commented 10 years ago

Ok, I like this a lot more with #79. I may auto label new scrambles if. I suspect it will be easier to write the code that way, and it just seems like better behavior to me. On Feb 26, 2014 3:58 AM, "jazzthief81" notifications@github.com wrote:

As suggested in issue #79https://github.com/cubing/wca-workbook-assistant/issues/79, I would like the scrambles to be added to the list of scrambles when the user drags and drops the scramble file.

When a new scramble file is opened, I would leave the scrambles as they were and let the user remove and/or add scrambles if required.

Reply to this email directly or view it on GitHubhttps://github.com/cubing/wca-workbook-assistant/issues/76#issuecomment-36117859 .

jazzthief81 commented 10 years ago

I now made it such that scrambles can only be added when a workbook is already open, and opening a workbook does clear the previous scrambles. It just seemed more logical that way after trying out the application for a while.