thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
333 stars 176 forks source link

WAC shown as WAPC in teams-committees page #10154

Open dunkOnIT opened 3 weeks ago

dunkOnIT commented 3 weeks ago

image https://www.worldcubeassociation.org/teams-committees-councils#wapc

This appears to be because of TeamsCommitteesCouncils/index.js:79

{`${I18n.t(`page.teams_committees_councils.groups_name.${activeGroup.metadata.friendly_id}`)} (${activeGroup.metadata.friendly_id.toUpperCase()})`}

It isn't clear to me where friendly_id is coming from, but it looks like it is stored as wapc in the code (I assume we're doing this to distinguish between old-WAC and WAPC) - because there's a difference between the software id and the public id, we can't just upcase the internal id.

dunkOnIT commented 3 weeks ago

@danieljames-dj you can probably confirm if my understanding of the issue is correct here

gregorbg commented 3 weeks ago

This is unfortunately a political war and mostly my fault. I've tried to convince WA(P)C (ie the Appeals people) that reusing an old, previously existing abbreviation "WAC" would be a terrible idea for oh so many reasons, but they keep insisting that "Nothing has broken yet, so we're fine".

The reason why we internally use wapc is that I deemed this the smart (because collision-free) abbreviation way before the mailing list or any internal team communication was formally established.

Unfortunately, there's not much I can do except telling them "I told you so" as soon as some unpleasant crash or leak occurs in the future because of this. But eh, let's change it to WAC if they insist on it so much.

dunkOnIT commented 3 weeks ago

A somewhat funny alternative would be to add i18n keys for the acronyms for the team names

gregorbg commented 3 weeks ago

funny alternative

You have a very interesting humor