thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
320 stars 175 forks source link

Multiple requests for one WCA ID are not deleted in "Notifications" #1825

Open Claster opened 7 years ago

Claster commented 7 years ago

A competitor created several accounts and requested me to confirm their WCA ID. After several emails I finally confirmed one of their accounts. Others are still shown in my "Notifications" though.

Probably once the WCA ID is confirmed, all other requests for this WCA ID should be deleted. Another option is to allow delegates to deny requests (an email to a competitor should be sent then).

jfly commented 7 years ago

Ha! Oh, people. Does this happen often?

Could you write up a proposal for the contents of the automated "your WCA ID claim has been rejected" email?

Claster commented 7 years ago

It doesn't happen often to me, only once. OTOH, I would like to delete claims because of the other reason as well, see below number 2.

Is it possible to have 1 WCA ID attached to several accounts? If not, is it possible to claim WCA ID that is already attached? What happens if the delegate accepts two claims, does the second one overwrites the first? Maybe we need another automated email for the event "your WCA ID was detached"? (Probably this is rare though)

Draft: "Hi,

Your claim for the WCA ID ${WCA_ID} was rejected.

Possible reasons:

If you have further questions, please contact the Delegate ${DELEGATE_EMAIL}."

jfly commented 7 years ago

What happens if the delegate accepts two claims, does the second one overwrites the first?

You cannot accept two claims. The first one will succeed and the second one will fail, complaining that you cannot assign the same WCA ID to 2 different accounts. To accept the second claim, you would have to manually clear the WCA ID associated with the first account before accepting the second claim. I don't think it's worth the effort of building any automated emails around this, delegates can send these emails manually. It's wroth noting that as we move towards a future with more competitions on the WCA website, and after we implement #21, the number of WCA claims should go down.

I'm confused by your proposed email, @Claster. I thought the point of this email was specifically for the case where your WCA ID claim has been automatically rejected because someone else's claim for the WCA ID was approved. The first two bullet points don't make sense in this scenario.

If you have further questions, please contact the Delegate ${DELEGATE_EMAIL}."

This is too much work for the user, I think we should instead send an email to both the delegate and the affected user, and set up the reply-to address to be the delegate's email. This way, the delegate knows that an email was sent, and the user just has to hit reply to contact the correct person.

shelchang commented 6 years ago

I have two notifications in my queue that I can't clear because the users have since had their WCA ID connected with a different account. There should be a "reject" option - what if someone requests the wrong ID by mistake (unlikely because of birthdate verification) or by malice (I don't know who'd want to do this but I assume the extra step of delegate verification is there for a reason)?

EDIT: I just realized that clearing the "unconfirmed WCA ID" field and then saving clears the request from the profile and from notifications. Would be more intuitive with an explicit "reject" button though.

jfly commented 6 years ago

@shelchang, I definitely agree that a dedicated page that says "This use has claimed this WCA ID, click here to approve, click here to reject" would be ideal.