Closed jfly closed 3 years ago
Why is this closed? You only fixed the footer thing...
It should not be closed! I had a typo in the commit which accidentally closed this one.
Actually, what's the plan with the Workbook Assistant? I mean, on a world with WCA Live in place it doesn't really make sense to still use something like it, right? Should the checks that the Work Assistant performs be added to the work @viroulep is doing as a part of https://github.com/thewca/worldcubeassociation.org/projects/4?
The plan is still to get rid of the Workbook Assistant (WA) in favor of having data entry tools (such as a the not-yet-existent WCA Live) upload results directly to the WCA website.
All the checks that the WA does that the WCA website doesn't do should get added to https://github.com/thewca/worldcubeassociation.org/projects/4.
Another critical thing the WA does is that it has a pretty fancy UI for merging scrambles and associating them with actual rounds that happened. We'd need to build some sort of UI on the WCA website for uploading/slicing/dicing scrambles before we can get rid of the WA.
All the checks that the WA does that the WCA website doesn't do should get added to https://github.com/thewca/worldcubeassociation.org/projects/4.
Sounds good! Do we perhaps have a list of those somewhere?
Another critical thing the WA does is that it has a pretty fancy UI for merging scrambles and associating them with actual rounds that happened. We'd need to build some sort of UI on the WCA website for uploading/slicing/dicing scrambles before we can get rid of the WA.
Yes, that will indeed be necessary.
Do we perhaps have a list of those somewhere?
Unfortunately, not one that I know of =( I think someone would have to read through the WA and compare it to what the WCA website does. Alternatively, it's possible that someone like @viroulep or @SAuroux might just happen to know off the top of their heads?
Off the top of my head I'd say that with all of Philippe's recent work, there might not actually be any check left that is only done by the WA. @viroulep what would you say?
Yep, I think what we need now is some kind of UI (that goes well into the expected WCA Live to website workflow) to be able to attach scrambles to a specific round, and generate the appropriate json :)
Wow, that's great news then! Based on this last comment, I'm adding the design
label to the issue. Once WCA Live is in place we can revisit this!
(CC'ing @jonatanklosko, as he's the one developing WCA Live.)
I tried to implement a drop-in replacement for the WA here: https://viroulep.github.io/scrambles-matcher/ (https://github.com/viroulep/scrambles-matcher for the source code)
People interested in testing it should feel free to do so :)
Closing this as we very actively use scrambles-matcher
now.
Great work, Philippe!
This would go nicely with #223. Some reasons why this makes sense: