Port /results/admin/ scripts to Rails

[jfly]

In preparation for porting the results admins cripts to Rails, @SAuroux just walked me through the uploading process for BASC 8. We had the opportunity to talk a bunch, and I made some notes about improvements we could make while doing the port:

• [x] check_results.php #977.
• [x] @SAuroux said that persons_finish_unfinished.php removes unknown characters when generating WCA IDs, but from code inspection, that's not what it appears to be doing: https://github.com/cubing/worldcubeassociation.org/blob/ea84c5642c66c61a4c6809346edbe454b2683cf3/webroot/results/admin/persons_finish_unfinished.php#L137. We should definitely write some tests for this code when we port it to Rails.
• [x] persons_finish_unfinished allows you to change someone's name and country, but the edit/change person script is a fine tool for that. It's also unclear what this script would do if you typed gobbledygook in as a new WCA ID.
• [x] persons_finish_unfinished and persons_check_finished should have that competition to select dropdown (see check_results) and should default to the competition whose results we're uploading, rather than all competitions.
• [x] persons_finish_unfinished is kind of annoying: you click update, and then it takes you to a different page (persons_finish_unfinished_ACTION, which we think can disappear). You end up having to click 2 more times just to get to the next list of 20 people to finish. @SAuroux agrees with me that it would be best to just show the next set of 20 people after clicking update.
• [ ] We should check what kind of scramble validations we have (are we comparing the number of scrambles we have to the number of solves we had in the round?) I (@jfly) wrote a bunch of checks for this inside the wca-workbook-assistant, but I don't know how many of those made it to the PHP code. @jbcm627 wrote that PHP code, he might remember. If not, we can dig into the code and find out. UPDATE: @jbcm627 has confirmed that the admin scripts just do a straight upload of the scrambles, they don't check how many scrambles there are. See code here.
  • [ ] check_rounds checks for missing/unannounced events, which is something that slips through because the workbook assistant doesn't check this.
  • [ ] https://github.com/thewca/worldcubeassociation.org/issues/3822
• [x] We should check that the registered DOB/country/gender of someone who registers with a WCA ID matches the one stored in the database
• [ ] We have to maintain the exact structure of the public facing database export page for a while, implement #60, and then notify people that they need to switch over to the new export url.
• [ ] Check that the current version of TNoodle was used for the competition.

[Luis-J-Ianez]

About your second point, remember that I completed the removeUglyAccentsAndStuff func in order for it to encompass all and any special char in the names in the database at the moment.

About persons_finish_unfinished, why are you planning to keep the 20-name batches? Can't we get rid of this and deal with all the competitors in the JSON file at one shot?

[jfly]

Yeah, I'm just worried about new unknown characters.

Sébastien and I both believe there's a real benefit to batches. Being able/forced to save your work midway through seems like a good idea. I worry about accidentally closing a tab midway through a large competition, for instance. That would be tragic.

[SAuroux]

bump

Unfortunately, porting these scripts to Rails did not happen in the past 19 months. This is mostly ok, but for a few cases we are sometimes severely limited by the "we don't extend old PHP scripts since they will be eventually be ported to Rails".

One such case is our check_records script. Whenever we have to retroactively change the nationality of a competitor, we would incredibly benefit from the possibility to check records by country. Right now, we have to check this manually which is an error-prone and tedious task.

As a results, I would like to ask to tackle this soon, either by extending the current PHP script or by porting the corresponding script to Rails.

[jfly]

As a results, I would like to ask to tackle this soon, either by extending the current PHP script or by porting the corresponding script to Rails.

@Baiqiang, do you have time to hack on check_regional_record_markers.php to add a "country" dropdown?

[dunkOnIT]

@gregorbg does this mean the same thing as "Port WRT admin to Ruby"? (Item from the March strategy paper)

[gregorbg]

Yes.

[danieljames-dj]

Many of the issues were tackled in the migration from PHP. Now, PHP is no longer a blocker for tackling remaining issues, so removing the PHP milestone from this issue.