search

thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
324 stars 175 forks source link

Reset instructions for Stripe aren't accurate #4919

Open notkevin888 opened 4 years ago

notkevin888 commented 4 years ago

Describe the bug Sometimes, organizers may want to change what Stripe account is set up for a particular competition. The current page blurb (If you ever want to disconnect your account, you can do so from your Stripe account dashboard here (please note it will revoke access for all competitions using the account).) suggests that organizers can go to their Stripe dashboard, revoke access to competitions, and then connect a different account. Unfortunately, that doesn't actually work, and it actually puts the competition into a bad state - the WCA side believes it's still connected, while the Stripe side correctly has removed access, which means it's impossible to correctly move forward.

To Reproduce Steps to reproduce the behavior:

  1. Create a competition, and set up Stripe using the Connect button.
  2. Revoke access by accessing Stripe's dashboard (either via the link on the WCA website page, or directly via Stripe).
  3. Confirm that Stripe has revoked access by not seeing the WCA application in the dashboard.
  4. Confirm that the WCA website has not updated accordingly, and still believes a Stripe account is connected.

Expected behavior Ideally, revoking access in Stripe should free up the WCA competition website from the previously-established connection, allowing a retry later with a different account.

If that's not reasonable, at least updating the blurb to say something like "If you want to reset your Stripe connection, please clone this competition and set it up there" (which is our current workaround).

Screenshots Skipping screenshots, as I feel like they wouldn't be that helpful, but I can backfill if you'd like :)

Desktop (please complete the following information):

Additional context Adam Walker ran into this problem before, and mentioned that it might be due to a WCA database to keep track of Stripe state; revoking access on the Stripe side may not update that database.

Jambrose777 commented 3 years ago

Is this still an issue? Admittedly, I'm too scared to try it with my own comps :P Def still an issue