Open viroulep opened 4 years ago
Oh and the test failed is:
rspec ./spec/requests/media_spec.rb[1:6:1:1:1] # media PATCH #update it should behave like only WCT when not signed in redirects to sign in page
It looks like our DB isn't consistent in the various emails column data types, is there a reason for it?
SELECT
TABLE_NAME, COLUMN_NAME, data_type, CHARACTER_MAXIMUM_LENGTH
FROM
INFORMATION_SCHEMA.COLUMNS
WHERE
COLUMN_NAME LIKE '%email%'
AND TABLE_SCHEMA = 'wca_development'
AND column_name NOT LIKE 'receive%'
AND column_name NOT LIKE '%allow%'
AND column_name NOT LIKE '%hash%'
AND column_name NOT LIKE '%time%'
ORDER BY 1 , 2;
Just came across your reply and no, there is no particular reason for it. While I can't tell for competitionsmedia and the archive stuff, the last 4 tables definitely should all have the same limit!
Hmm we should probably align them at some point.
This popped up in one of travis' builds:
We should look into FactoryBot's settings to have emails below a given threshold, but most importantly we should fail registration for users with emails above what our db supports!