search

thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
329 stars 176 forks source link

Result-based advancement condition is conveyed incorrectly #5176

Closed jonatanklosko closed 3 years ago

jonatanklosko commented 4 years ago

That's what result-based advancement condition means:

9p2+) CLARIFICATION Result refers to the single or average that determines the ranking of the corresponding round.

On the contrary, the current wording clearly refers to single attempts:

https://github.com/thewca/worldcubeassociation.org/blob/20cc8f080e0f605fbbaf405563b9d0a7c01ef635/WcaOnRails/config/locales/en.yml#L153-L156

https://github.com/thewca/worldcubeassociation.org/blob/20cc8f080e0f605fbbaf405563b9d0a7c01ef635/WcaOnRails/config/locales/en.yml#L159-L162

Also see https://github.com/thewca/wca-live/issues/54.

viroulep commented 4 years ago

I think that's a duplicate of #3597.

jonatanklosko commented 3 years ago

Closing in favor of #5661.