thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
330 stars 176 forks source link

Make "persons" result validations easier to validate #7166

Open timreyn opened 2 years ago

timreyn commented 2 years ago

image

It's a little tedious to confirm whether these are new people -- in order to check their dates of birth, I need to:

This page could have more information to make it easier. Suggestions:

Jambrose777 commented 2 years ago

Hey! I agree the process and wording can be improved.

I have some concerns from a Data protection perspective. Primarily, we should add PII to emails more than we have to (ideally we would remove all PII from emails and only have that on the WCA website, but that's a long term thing). So I would be against providing the DOB in the email and even in the Warning.

What I can recommend is changing the duplicate persons warning to only trigger upon the following circumstances instead:

I think that this would reduce the amount of these warnings given and still provide Delegates correct warnings whenever they miss a duplicate competitor. For other cases (like a similar DOB) the WRT can always investigate those / bring those concerns to the Delegate while posting results. But those cases are rare as is, so it might be best to handle them outside of these warnings.

I would like @thewca/wrt to take a look at the proposal and this and leave comments if needed.

timreyn commented 2 years ago

Good point, @Jambrose777 ! I agree with not putting more PII in emails; I was only thinking about the version shown on the webpage, but I guess it's not that easy to have different text in the email and on the webpage.

But I like your proposal better! I would still also add that the WCA ID should be linkified when the warning does come up.