search

thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org
https://www.worldcubeassociation.org/
GNU General Public License v3.0
326 stars 175 forks source link

Results validator doesn't report incorrect scramble sets for 333mbf #7546

Open viroulep opened 1 year ago

viroulep commented 1 year ago

@Jambrose777 implemented a check that scramble sets match what is declared on the manage events page in #5799, but it currently doesn't properly report missing scramble sets for 333mbf.

Maybe I'm missing something but it looks like it could work for 333mbf as well. The event is given a weird treatment here, where we add a specific error for MBF if needed.

But I think the scramble sets validation is independent from the groups one, and moving the block of code below the 333mbf logic (and adding the errors to the actual @error variable) should work. @Jambrose777 did you notice the weird implementation and were you expecting the validation to not work for 333mbf?

viroulep commented 1 year ago

We did have a talk about this; basically the error detection Jacob added should definitely work for 333mbf, we just need to add it unconditionally and rework how the 333mbf detection works when dealing with scrambles sets with different number of attempts.