Markdown rendering issue for delegates report

thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org

https://www.worldcubeassociation.org/

GNU General Public License v3.0

326 stars 175 forks source link

Markdown rendering issue for delegates report #756

Closed viroulep closed 4 years ago

viroulep commented 8 years ago

It seems that we don't use the same rendering for the report fields' preview and for viewing the full report.

Here is a few differences I spotted:

Fields preview allows lists to break paragraph, full report view doesn't (meaning you have to have a blank line before the list to display it properly, see here vs here).
Fields preview renders links for http(s) urls automatically, full report view doesn't.

If we can I'd vote for using the fields preview rendering everywhere, but at least we should use the same rendering for both views, or provide a disclaimer about these differences on the edit report page.

jonatanklosko commented 8 years ago

Will be fixed after #719 is merged =)

viroulep commented 8 years ago

It has been merged so I looked back at it :) The default behavior is to not create links automatically, and create lists only if there is a blank line before them.

It remains one tiny thing that is a bit misleading regarding this default behavior: when typing an url, the "preview as you type" will render a link (actually it just underlines it), whereas the actual preview won't. By just looking a bit into it, it seems that the "preview as you type" uses another css (than the website's), but unfortunately the style is the same for two links where we'd like different behaviors: links

I'm not sure there is an easy fix for this...

viroulep commented 4 years ago

This is not relevant anymore since we switched to EasyMDE (#4376).