Remove avatar when deleting an account/moving WCA ID instead of serving an error to the user

thewca / worldcubeassociation.org

All of the code that runs on worldcubeassociation.org

https://www.worldcubeassociation.org/

GNU General Public License v3.0

320 stars 175 forks source link

Remove avatar when deleting an account/moving WCA ID instead of serving an error to the user #8707

Open dunkOnIT opened 7 months ago

dunkOnIT commented 7 months ago

Currentyl when trying to transfer a WCA ID or delete an account, the user is informed that they have to first remove the avatar. This is annoying for the informed user and confusing for the uninformed user.

We should instead flash a warning saying the the avatar will be deleted, requesting confirmation.

I think this is better than silently deleting it, as it may not be obvious that deleting the WCA ID (not the user account) would cause the avatar to be removed).

dunkOnIT commented 7 months ago

I don't think this is a first issue as a lot of the avatar handling code look confusing (to me at least)