Closed altunenes closed 3 months ago
The problem I had in Vibe is that ort link msvc statically by default but if cuda enabled it link it dynamic. Also whisper link it dynamic by default. And I discovered that Rust's standard is to link msvc dynamic. So I changed all the libraries to link it dynamic by default.
But I think in your end the issue is that you didn't updated whisper-rs (new commit) Run
cargo update -p whisper-rs
And then
cargo clean -p whisper-rs -p whisper-rs-sys
To control msvc linkage you can set KNF_STATIC_CRT
or WHISPER_USE_STATIC_MSVC
to 1
or 0
depending on the issue. (must clean their crates with -p name
and rebuild)
oh, interesting!
and thank you!!
Does it worked?
yes its worked
But I think I will continue with the sherpa-rs + pyannote anyway. I found it much better than whishper-rs thanks to you!
seems this is fixed with a new ort also. can you update the ort? maybe this will make it even more stable with Whishper?
note that:
https://github.com/pykeio/ort/commit/069ddfdd2c1e8af0ea637ac40082ee176ebf870d ort now depends on ndarray 0.16.
I updated and released new version for pyannote-rs. At least we learned something new: stick to dynamic msvc link and match across all crates / libs.
oh, thank you! didn't expect that you are too fast haha!
Thank you, appreciate!
2.2 and 2.3 is working without any problem. but those versions always give this annoying error.
my current cargo file:
when I look at the vibe's cargo file https://github.com/thewh1teagle/vibe/blob/main/core/Cargo.toml, I see you use 0.2.5 but no build error, strange...