search

thewhiterabbit / Deploy_Saleor

37 stars 22 forks source link

Fix os detection and make sudo command as optional #12

Closed Geeknux closed 8 months ago

Geeknux commented 8 months ago

I tried to use this script on my Debian 11 server, but got some issues, the first one, it doesn't detect my OS so i fix the os detection and how to check the os codes, then i run it as root, and got sudo not found for my situation, so i add a Function to run commands, and make it as an optional choice to use sudo command or not using it if the current user it root

don't know it's a good change or not but i think maybe it worth to send a pull request to share my changes to your code base.

Kind regards

Geeknux commented 8 months ago

it cause many error to run the script as root, so i think it's a good idea to close it, however, the detecting os still valid