search

thewhitetulip / build-app-with-python-antitextbook

Aims to teach Python3 by example
GNU General Public License v3.0
557 stars 69 forks source link

Jaivasani patch5 - No change in code #34

Closed jaivasani closed 7 years ago

jaivasani commented 7 years ago

Fixed my email address in git bash to point my commits to the correct account. Issue: My email address was not set in git, hence github wasn't recognizing my commits.

Before adding email to git: image

After adding email to git: image

This is probably the reason why it is showing my previous commits as new commits.
Please ignore this pull-request if this is not the correct way. (New to Github. Thanks!)

thewhitetulip commented 7 years ago

It shows me lot of code changes. Let me look inyo it if I can edit the git history to update your email ID. Please give me your github email ID. If that doesn't work, then we'll merge this.

jaivasani commented 7 years ago

my old email ID as per git was Jai Vasani my github email ID is jsvasani@gmail.com

If its too much trouble then you can just go ahead and delete this pull-request without merging. Thanks!

thewhitetulip commented 7 years ago

Forget it, I'll merge, if there is some issue, we can see it later!