thewierdnut / endless-mobile

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
92 stars 6 forks source link

Do not auto-load and re-save saves if the game is in crash-recovery mode #103

Closed thewierdnut closed 6 months ago

thewierdnut commented 7 months ago

Is there an existing issue for this?

Describe the bug

If the game crashes on startup, then when it first loads with disabled plugins it modifies and re-saves, possibly messing up ships and outfits due to the missing plugins.

Steps to Reproduce

Load lots of plugins, create ships based on those plugins

Load more plugins, until it induces a crash-on-load

Restart, note the error messages for the game load, and note that all of the outfits have been removed from your ships (and possibly saved over your old save game in that state)

Expected Behavior

In a crash-recovery state, the save game should not be automatically loaded (and also not automatically saved).

If the save relies on a plugin, you probably shouldn't allow the user to load the game at all, unless they explicitly disable the plugin and restart.

Screenshots

No response

Link to save file

No response

Device type

asdf

Game Version

37

Additional Information

No response