search

thewierdnut / endless-mobile

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
92 stars 6 forks source link

Non responsive UI #92

Closed YiffLord closed 8 months ago

YiffLord commented 9 months ago

Is there an existing issue for this?

Describe the bug

The UI does not respond when selecting ships in the shipyard menu. Upon tapping a different ship icon the action will often be ignored, as if you never tapped. This is especially common when attempting to select another ship after having already selected one.

Steps to Reproduce

  1. Go to shipyard menu.
  2. Tap on any ship icon.
  3. Repeat and observe that it is a fairly common occurence.
  4. Unprofit.

(thewierdnut, note to self:) Brokenness 1:

  1. Go to the shipyard screen
  2. Select more than one of "Your Ships:" on the right side of the screen.
  3. Select a ship for sale on the left side of the screen. Note that the set of selected ships is not preserved.

Brokenness 2:

  1. Go to the shipyard screen
  2. Select one or more of "Your Ships:" on the right side of the screen.
  3. double-tap on one of the ships for sale on the left side of the screen. Note that all ships on the right are deselected.

(YiffLord additional issue:) [Delete if no issues found]

  1. Go to the shipyard screen.
  2. Select one or more of "Your Ships:" on the right side of the screen.
  3. Double-tap a ship for sale/tap with rather quick succession multiple ships for sale.
  4. Note that in addition to deselecting "Your Ships:", the selection of ships for sale becomes stuck/unresponsive, preventing the user from selecting other ships for sale for a certain period of time.

Expected Behavior

The action should be processed.

(thewierdnut, note to self:) The selection logic on the for-sale (left side) and "Your Ships:" (right side) should not affect each other.

Screenshots

/

Link to save file

/

Device type

Overclocked Samsung Tab S2 9.7 Black

Game Version

Latest continuous as of the 23rd of July 2023.

Additional Information

It is not game breaking, but it's amazing how such a small error can be so infuriating. Thanks for your efforts btw.

thewierdnut commented 9 months ago

I've seen some complaints on discord about the selection being "sticky". I'm not seeing any unexpected behavior, but maybe I'm biased because I know what to expect.

I'm assuming you are talking about the ship selection area here: image

I've implemented three custom behaviors here:

1) A double-tap will select all contiguous ships the same type as the one double-tapped, unselecting all other ships. 2) A long tap will select or unselect the the tapped ship. 3) Tapping a ship when it is the only ship selected should unselect it (ie no ships will be selected)

Upstream behavior that should still work: 1) Tapping a single ship (when it isn't already the only selected ship) should select that ship, deselecting all others. 2) Dragging and dropping to rearrange ships.

Will you let me know what specific behavior is broken?

YiffLord commented 9 months ago

No, I was talking about the purchase ship selection, not your existing fleet.

I haven't had any issues with the fleet selection UI, it seems to work accordingly, atleast on my behalf.