search

thewierdnut / endless-mobile

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
92 stars 6 forks source link

ammo counters are covered by map buttons #94

Closed thewierdnut closed 8 months ago

thewierdnut commented 9 months ago

Is there an existing issue for this?

Describe the bug

The ammo counters for secondary weapons are hiding underneath the map buttons in the bottom right corner

Steps to Reproduce

get a ship with secondary weapons, and got to the screen. you can see them being drawn underneath the buttons

Expected Behavior

They should probably be moved somewhere more useful: image

Keep in mind that moving the bounding box isn't quite sufficient, as the secondary weapons are drawn from the bottom up in order, making aligning them to the top of the screen difficult, as we don't know how many weapons the user has. We will need to allow ammo display to modify its drawing direction depending on the aligned screen boundary.

Screenshots

No response

Link to save file

No response

Device type

asdf

Game Version

37

Additional Information

No response

thewierdnut commented 8 months ago

It turns out these are drawn on accident. They are supposed to be disabled by the "Show buttons on map" preference, which got botched and disabled by a merge.

I'm going to restore the original behavior (which was not to draw them at all if the buttons are there), and if somebody needs them somewhere else, lets create a new issue for it.

YiffLord commented 8 months ago

Alright, sounds like a fair idea to me.