search

thewildpendulum / angular-phonegap-seed

A barebones seed project for getting started with PhoneGap and AngularJS (with routing!)
107 stars 26 forks source link

Use with Angular 1.1.5 #1

Closed Gwash3189 closed 11 years ago

Gwash3189 commented 11 years ago

Thanks for making this project. I've recently used it in a project and it's a great starting point. Although with the release of angular 1.1.5 the app.js file is no longer needed when using cordova 2.7.0.

Angular actually bootstraps it self. I am not 100% on how but i believe that angular either listening for the DeviceReady event it self, or cordova fires another, recognized event.

thewildpendulum commented 11 years ago

Thanks for the update. I'll try to get to this soon, but feel free to submit a pull request in the meantime.

thewildpendulum commented 11 years ago

You're right, Angular does bootstrap itself, though it does so independently of Cordova. My original thinking in app.js was to delay Angular loading until the Cordova APIs were available. After reading up on the issue, however, I've included a better method for handling that.

thewildpendulum commented 11 years ago

Fixed in b1d62249d7c4f8dc6a17f5749d768d3756a53a14

Gwash3189 commented 11 years ago

Hey @thewildpendulum, sorry for the late reply, thanks for looking into that.