search

thewml / website-meta-language

An old offline HTML preprocessor (which can be used for static site generation), written in Perl and C that is still maintained for legacy reasons, but probably not recommended for new sites.
https://www.shlomifish.org/open-source/projects/website-meta-language/
GNU General Public License v2.0
14 stars 8 forks source link

Fix multiple syntax issues in wml, wmk, and ipp #13

Closed xtaran closed 5 years ago

xtaran commented 5 years ago

Contains fixes for #10 and #12, one commit per fix.

Feel free to cherry-pick single commits out of this pull request in case you don't want to merge all three commits.

xtaran commented 5 years ago

Hrm, I think I see what causes the CI failures. Will push a fix for that soon. Interestingly it didn't bail out when building my site. :-)

shlomif commented 5 years ago

@xtaran : hi! Thanks, but note that I fixed an issue in somewhat different way and now there is a conflict. Please fix the Pull-req. Thanks!

xtaran commented 5 years ago

@xtaran : hi! Thanks, but note that I fixed an issue in somewhat different way and now there is a conflict.

Saw it, thanks.

Please fix the Pull-req. Thanks!

Done.

xtaran commented 5 years ago

Hrm, this time I'm not sure what broke. Definitely less than last time, but for me locally the test suite exits immediately, so I can't really test locally:

[…]te-meta-language/src → make test
Running tests...
Test project /home/abe/wml/website-meta-language/src
    Start 1: wml_tests
1/1 Test #1: wml_tests ........................***Failed    0.71 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.72 sec

The following tests FAILED:
          1 - wml_tests (Failed)
Errors while running CTest
make: *** [Makefile:120: test] Error 8

Any hints on either the failing Travis CI or on my local issue? If so, I'm happy to further debug the issue.

xtaran commented 5 years ago

Ah, AppVeyor is more clear. Will tidy up that one long line which even got longer.

xtaran commented 5 years ago

(It's IMHO still dicussable if it's more readable that way. :-)

xtaran commented 5 years ago

Ah, you've fixed it yourself. Thanks! Hence closing.

shlomif commented 5 years ago

Hi!

I fixed the perltidy tests in a separate commit. Thanks!