Closed tonycoz closed 5 years ago
Thanks! Trying.
Applied, but the problem persists - https://ci.appveyor.com/project/shlomif/website-meta-language/builds/20375344 .
On Sat, Nov 17, 2018 at 09:41:36AM -0800, Shlomi Fish wrote:
Applied, but the problem persists - https://ci.appveyor.com/project/shlomif/website-meta-language/builds/20375344 .
It may not make a difference, but your fix is incorrect:
You added:
myargv[myargc++] = NULL;
so if myargc was 2, it will be 3 and myargv[myargc] still won't be NULL.
This should be:
myargv[myargc] = NULL;
Tony
On Sat, 17 Nov 2018 14:58:32 -0800 Tony Cook notifications@github.com wrote:
On Sat, Nov 17, 2018 at 09:41:36AM -0800, Shlomi Fish wrote:
Applied, but the problem persists - https://ci.appveyor.com/project/shlomif/website-meta-language/builds/20375344 .
It may not make a difference, but your fix is incorrect:
You added:
myargv[myargc++] = NULL;
so if myargc was 2, it will be 3 and myargv[myargc] still won't be NULL.
This should be:
myargv[myargc] = NULL;
Thanks, Tony! I meant it to be this way. Fixed now and pushed.
Tony
Shlomi Fish http://www.shlomifish.org/ Humanity - Parody of Modern Life - http://shlom.in/humanity
God signs people into the book of life using a pen that Chuck Norris gave him. — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/
Please reply to list if it's a mailing list post - http://shlom.in/reply .
Still fails - https://ci.appveyor.com/project/shlomif/website-meta-language .
https://github.com/thewml/website-meta-language/blob/4b13b8a8e2347b08280a38929cd4e77dabdbdbb7/src/p3_eperl/eperl_main.c#L87
I don't know if that's the cause of the problem you raised in #p5p, but it is enforced recently (rather than possibly crashing).