thewml / website-meta-language

An old offline HTML preprocessor (which can be used for static site generation), written in Perl and C that is still maintained for legacy reasons, but probably not recommended for new sites.
https://www.shlomifish.org/open-source/projects/website-meta-language/
GNU General Public License v2.0
14 stars 8 forks source link

refactor & correct typos in wml::fmt::text #42

Closed shlomif closed 4 years ago

shlomif commented 4 years ago

Hi @xtaran !

Please review this pull-req. I'm not using wml::fmt::text a lot and would rather not break it.

xtaran commented 4 years ago

Hmmm, as far as I can see, we don't really have a test for that. Since I don't remember to use that anywhere, I'd write a test (likely in the master branch) and see if it also passes in the feature branch.

shlomif commented 4 years ago

On Mon, 31 Aug 2020 08:00:12 -0700 Axel Beckert notifications@github.com wrote:

Hmmm, as far as I can see, we don't really have a test for that. Since I don't remember to use that anywhere, I'd write a test (likely in the master branch) and see if it also passes in the feature branch.

Thanks, @xtaran !

--

Shlomi Fish https://www.shlomifish.org/ https://www.shlomifish.org/humour/bits/facts/Taylor-Swift/

Always reach for the stars! Because even if you miss… You’ll be miles away from me with your motivational bullshit. — https://is.gd/PuH02m

Please reply to list if it's a mailing list post - https://shlom.in/reply .

xtaran commented 4 years ago

Sigh, seems as we've crossed each other in fixing the test failure due to a missing txt2html.

xtaran commented 4 years ago

Wanted to fix this in the test itself before adding it to .travis.yml and .appveyor.yml to make sure the check in the test itself works.

xtaran commented 4 years ago

Testing this now via branch at https://github.com/thewml/website-meta-language/tree/skip-wml-fmt-text-if-txt2html-not-installed

xtaran commented 4 years ago

Thanks, for some reason I was not able to get perltidy to emit these errors, even with the included .perltidyrc.