search

thewongdylan / pe

0 stars 0 forks source link

Appointment dates can be before today's date #4

Open thewongdylan opened 5 months ago

thewongdylan commented 5 months ago

Description Appointment dates added under d/DATE_OF_BIRTH using the addv and editv commands accept dates before today's date, despite the UG stating that appointments are supposed to be records of a patient's future scheduled appointments at the clinic, implying that appointments must be in the future while visits must be in the past Screenshot 2024-04-19 at 5.02.35 PM.png

Steps to reproduce

  1. Launch the application for the first time to load sample data
  2. Run edit 1 o/18/04/2023

Expected behaviour The app should reject the input appointment date as it is before today's date

Actual behaviour The app accepts and saves the input date despite it being before today's date. Screenshot 2024-04-19 at 4.58.48 PM.png

Reason for severity Affects usage, since there is now overlap between visits and appointments that is not checked by the app

nus-se-script commented 5 months ago

Team's Response

Thank you for raising this. This behaviour is intended to give flexibility to the user, which aligns with module expectation, and would not cause inconvenience for the user in most cases. However, we believe the issue here is in the use of our word "future" in the user guide (shown in the screenshot provided), which might have given off the impression that we validate the appointment date. Therefore, we have decided to change the bug type to documentation, but will still accept this as a bug.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]