search

thewtex / ngff-zarr

A lean and kind Open Microscopy Environment (OME) Next Generation File Format (NGFF) Zarr implementation.
https://ngff-zarr.readthedocs.io
MIT License
21 stars 4 forks source link

nested separator in to_ngff_zarr, fixed napari display problem #46

Closed GFleishman closed 1 year ago

GFleishman commented 1 year ago

This fixes https://github.com/thewtex/ngff-zarr/issues/45

I noticed calls to to_zarr in the to_multiscales function as well, but I think they're just cache for large files and not meant as ome-ngff-zarr outputs so I did not add a dimension separator for them.

You can also specify the dimension separator when you create the array (i.e. zarr.creation.open_array) but since you don't always do this explicitly I let the dask.array.to_zarr function do it.

Not sure if you want the dimension separator to be a user settable thing instead of hardcoded like this? If it's going to be standard practice for ome-ngff-zarr to use '/' and if some programs won't even support '.' then maybe compulsory like this is better, but your choice.

GFleishman commented 1 year ago

I have no idea how adding a keyword argument to an internal function would cause doc build to fail?

thewtex commented 1 year ago

I have no idea how adding a keyword argument to an internal function would cause doc build to fail?

@GFleishman I likely added the initial docs after you created the branch for this PR.