thexaero / Better-PVP-Translations

Translations to different languages for the Better PVP Minecraft mod.
Creative Commons Zero v1.0 Universal
8 stars 22 forks source link

added missing keys to ja_jp file #1

Closed graycat27 closed 4 years ago

graycat27 commented 4 years ago

based on en_us.lang

added some missing keys only that which I could check how these options works.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

thexaero commented 4 years ago

Thanks for the contribution! You did a great job. The lines that you added seem to mean exactly what they are supposed to even after translating them back with Google Translate. This isn't always the case, so that's awesome. Although I have noticed that you have translated some tooltips for options that don't have a translation for their name. For example, "Entity Name Tags". And I also found one where the actual option values are translated but not the option name: "Main Entity As". Might be other ones too. Seems a bit weird. Not sure if you're aware of that. Also, some tooltips are REALLY long in width because they contain no spaces. They still fit the screen but it looks a bit strange. I assume it's because spaces are not used in Japanese but you can still use them here for line breaks, as done by the previous translators.

We can leave it like that for now but, if you could fix this stuff, I would definitely appreciate it! Would probably be a good idea to add the untranslated English lines in between, for future translators, but I can do that myself, so no worries. I wonder if you weren't able to test the file because of it being a .lang and not a .json? I still support older MC versions and I made myself a .lang to .json converter a while back to port the mods. This is why the repo contains .lang files. You can test the file on 1.12.2. Perhaps I should make a .json to .lang converter too, and share it.

graycat27 commented 4 years ago

Thanks for giving me a comment.

I wonder if you weren't able to test the file because of it being a .lang and not a .json?

Thanks to the hint that langs are stored with json, I was able to check the display of the Japanese which I added. I checked the latest 1.16.1 forge mod jar file. I replaced the json file with the one I edited with 7-zip.

So, I understand what you said as...

some tooltips are REALLY long in width because they contain no spaces.

It's because as you guessed, Japanese doesn't need white-spaces. I inserted some white-spaces in a long one.

Would probably be a good idea to add the untranslated English lines in between, for future translators, but I can do that myself, so no worries.

I think its a good idea! In this commit, I didn't do this for now, but it may helps future translators.

graycat27 commented 4 years ago

thanks for your review. I'll fix these tomorrow (≒ in about 20h later), its 11PM here so i'm going to sleep tonight.

thexaero commented 4 years ago

Alright, I appreciate it! No hurry at all.

graycat27 commented 4 years ago

checked with the latest forge 1.16.1 jar (20.20.1) I didn't reflect my self review

L218 gui.xaero_cave_zoom should be "洞窟でのズーム倍率" L231 still over flow the button width

because, L218's option is able to set "OFF". and some other options are also overflow, so I thought not necessary to fix now.

thexaero commented 4 years ago

Good job! Looks good to me right now. Thank you so much for this! Don't worry about the slight overflow. I think I'm going to increase the button width slightly in the future. It doesn't currently work too well for English either. Let me know if you think the PR is ready for merge.

graycat27 commented 4 years ago

I think this PR is ready for merge :)

thexaero commented 4 years ago

Alright! Thank you. I really appreciate it. I'm probably going to include this in the following update after 20.20.2, since that one is already out for patrons.