thexaero / Better-PVP-Translations

Translations to different languages for the Better PVP Minecraft mod.
Creative Commons Zero v1.0 Universal
8 stars 22 forks source link

Some text strings are used in older Minecraft versions only #15

Closed Greg-21 closed 2 years ago

Greg-21 commented 3 years ago

UPDATED TO REFLECT THE STATE FROM BETTER PVP VERSION 21.16.0 AND 21.10.6.

I tested multiple versions of your Better PvP mod, and found a few text strings that are exclusive to specific Minecraft versions. These text strings are listed an grouped below.

For every group, I will have a question. I would be grateful if you could answer these questions.

(1) Only used up to and including 1.16:

(2) Only used in 1.14 and newer:

(3) Only used up to and including 1.12:

(4) Only used up to and including 1.8:

Ad 1: Why it has been removed in 1.17? Do you plan to bring it back or it will stay that way from now on? Ad 2: It is probably impossible to backport due to Minecraft/Forge API limitations or simply not worth the effort, but I would like to make sure. Ad 3: This is probably an oversight. In 1.12 the new text string that superseded this one should be used, as 1.12 has the new ceiling detection. Ad 4: Versions 1.8 and 1.7 are currently stuck on an older mod version. Will this change in the future? What is your plan here?

thexaero commented 3 years ago

Thank you for the feedback!

  1. It was removed because render layers don't exists in 1.17. Never existed on Fabric so the option did nothing and now Forge completely reworked their UI system.
  2. You can't teleport to another dimension pre 1.14.
  3. Didn't realize this was the case. Really appreciate it!
  4. I'm only going to release bug fixes and update translations for 1.7 and 1.8, so these lines are necessary for that purpose. I might drop updating translations but haven't decided yet.
Greg-21 commented 3 years ago

Thank you for the explanation. I have one more question, how long are you going to support 1.8 and 1.7? Any estimates?

thexaero commented 3 years ago

Sorry for not responding sooner. I'm not sure. Probably a long time.

thexaero commented 2 years ago

I think this is "resolved" now, so I'm closing the issue.