thexaero / open-parties-and-claims

Minecraft mod that adds chunk claims and player parties
https://www.curseforge.com/minecraft/mc-mods/open-parties-and-claims
Other
34 stars 15 forks source link

Forceload not working for server claims. #392

Closed NiliusJulius closed 6 months ago

NiliusJulius commented 7 months ago

I'm playing on a server, and have created some claims in server-claim-mode. If I mark these as forceloaded, and leave the area, they do not keep the area loaded, but if I make a player claim and forceload them, it does.

One thing that does work is: If a chunk is forceloaded by for example the /forceload command, and in the server claim settings, forceload offline has been turned on, the forceload offline does get applied, so it seems to just be the forceload part that does not work.

This is on 1.20.2

thexaero commented 7 months ago

I'd be surprised if this is actually true. How are you testing whether chunks are forceloaded or not? Is regular forceloading turned on in the server claim config?

The /forceload command does not care about anything in this mod. It would forceload the chunk no matter what you configured. You shouldn't use that to test anything related to the mod.

NiliusJulius commented 7 months ago

We first noticed it with a bonemeal farm. To test I go to a random chunk which I forceload as server-claim, setup a dropper which empties its contents automatically and then teleport 20 chunks away. When I tp back to the forceloaded chunk a minute later, the dropper has not emptied.

thexaero commented 7 months ago

I see, that's a good way to test it. So is regular forceloading enabled in the server claim config? Please double-check.

NiliusJulius commented 7 months ago

Yes that is turned on image

thexaero commented 7 months ago

Interesting. I'll look into it.

thexaero commented 7 months ago

Is this Forge or Fabric?

NiliusJulius commented 7 months ago

Fabric

thexaero commented 7 months ago

Thanks, I'll check it out.

thexaero commented 6 months ago

Seems to be working in all my tests. I don't even remember how server claim forceloading is any different from player claim forceloading besides having unlimited forceloads. I don't think it is any different, which isn't making any sense in regards to this issue. I'll make sure though.

thexaero commented 6 months ago

I think I know what might be wrong. It is in fact related to server forceloads being unlimited.

thexaero commented 6 months ago

Yep, can confirm. The limit is still enforced when forceload tickets are being added. If you toggle forceloading off and on, it'll update the tickets and ignore limits for server claims, fixing the issue.