search

thexaero / open-parties-and-claims

Minecraft mod that adds chunk claims and player parties
https://www.curseforge.com/minecraft/mc-mods/open-parties-and-claims
Other
34 stars 15 forks source link

Server Crash with OPAC #410

Closed starplasam626 closed 6 months ago

starplasam626 commented 6 months ago

The server keeps crashing when a player logs in. 2023-12-25-2.log.gz debug-2.log.gz crash-2023-12-25_12.15.20-server.txt

Lemmmy commented 6 months ago

I'm not terribly familiar with the code, but I believe fde9fbd removed an instanceof that was acting as a null check for p:

https://github.com/thexaero/open-parties-and-claims/blob/6c62d22f4c84ebadecb3c749319e25c699862428/Common/src/main/java/xaero/pac/common/server/claims/protection/ChunkProtection.java#L325-L326

https://github.com/thexaero/open-parties-and-claims/blob/6c62d22f4c84ebadecb3c749319e25c699862428/Common/src/main/java/xaero/pac/common/server/claims/protection/ChunkProtectionEntityHelper.java#L91

thexaero commented 6 months ago

Thanks for reporting! @Lemmmy You're right, thanks!