search

thexaero / open-parties-and-claims

Minecraft mod that adds chunk claims and player parties
https://www.curseforge.com/minecraft/mc-mods/open-parties-and-claims
Other
37 stars 19 forks source link

Claims not loaded after going through a portal #484

Closed riddemon closed 3 months ago

riddemon commented 3 months ago

After you go through a portal (nether portal in my testing, haven't tested end portals) the chunk claims are not loaded for the player.

(meaning players have no indicator of which claims they are in)

riddemon commented 3 months ago

Screenshot from 2024-06-15 11-25-05 Screenshot from 2024-06-15 11-24-58 Screenshot from 2024-06-15 11-25-10

Note the claims disappearing as they are loaded in the map. Exiting and joining back in the server allows the claims to be read as normal.

thexaero commented 3 months ago

Is there anything unusual about the server I should know? This seems to be the only server that is experiencing this. Please also tell me your Minecraft, mod, Forge/Fabric/NeoForge versions.

thexaero commented 3 months ago

And please send me the openpartiesandclaims-server.toml config file

riddemon commented 3 months ago

openpartiesandclaims-server.txt File type is changed in .txt so that I could have it here

thexaero commented 3 months ago

Thanks! I'll look into it.

thexaero commented 3 months ago

When you talk about going through the Nether portal, you mean the vanilla function of the Nether portal? Going in the Nether? Are claims unloaded in the Nether as well?

riddemon commented 3 months ago

Yes, and yes

riddemon commented 3 months ago

@thexaero any update?

thexaero commented 3 months ago

I can't work on my mods that much atm because I'm sick. You can investigate this further for me, if you want to speed things up when I get to this. Try testing in singleplayer and/or without some of your mods.

riddemon commented 3 months ago

oh no! I hope you get better soon!

thexaero commented 3 months ago

Oh wow, it's not even a compatibility issue with another mod. I was just able to reproduce this. Weird how nobody else is reporting the issue.

riddemon commented 3 months ago

The joys of being a professional software tester: you find bugs

On Fri, 21 Jun 2024, 09:24 thexaero, @.***> wrote:

Oh wow, it's not even a compatibility issue with another mod. I was just able to reproduce this. Weird how nobody else is reporting the issue.

— Reply to this email directly, view it on GitHub https://github.com/thexaero/open-parties-and-claims/issues/484#issuecomment-2182162939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDJIYP4EDGWGKLGBZX3R3TZIPIJXAVCNFSM6AAAAABJLRMATSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGE3DEOJTHE . You are receiving this because you authored the thread.Message ID: @.***>

thexaero commented 3 months ago

Alright, seems like Fabric started handling packets in a scheduled main thread task with 1.20.6, affecting the order in which some packets are handled in relation to vanilla ones. This made the client mistakenly assume that the server doesn't have OPAC installed. Seems very easy to fix the issue though.