thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

opinion page printing option/disable printing option #1151

Closed ronm123 closed 1 year ago

ronm123 commented 2 years ago

I received a question about the new opinion page printing option and after my own tests I'm not sure if this is working as it should be or what the answer is. The question/comment was: "I can see and add the 'Disable printing' Optional Property on an Opinion Page. Can you please tell me where the Print is. I cannot see a difference between having this setting, without this setting, tick it and untick it."

I tested this and I can replicate this with latest 3.11 and develop e.g. don't add the disable printing optional property, click submit and the print button appears. add and tick the disable printing optional property. click submit the print button still appears. Also although it's labelled as Print there isn't a language option to change that or a tooltip to explain that this is actually to create a pdf that you can then print rather than directly a print option - or am I missing something here? Finally I guess it doesn't matter too much in this case but given that the print button wasn't there previously should the optional property be to show rather than hide the button?

ronm123 commented 2 years ago

Sorry perhaps should have added this to https://github.com/thexerteproject/xerteonlinetoolkits/issues/789 rather than create a new issue?