search

thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Bootstrap --> accordeon --> add video --> hide title does not work #1160

Closed ingedonke closed 1 year ago

ingedonke commented 1 year ago

In a bootstrap template, with a video in an accordeon navigator, the hide title function does not work. image

FayCross commented 1 year ago

Related to https://github.com/thexerteproject/xerteonlinetoolkits/issues/1024? Probably something to discuss at a dev day as we need a way that's not going to cause problems with existing projects

ronm123 commented 1 year ago

@FayCross lets discuss this quickly when we meet again this afternoon. As you say it's similar or related to https://github.com/thexerteproject/xerteonlinetoolkits/issues/1024 and in that issue I mentioned that we thought we had a solution. I think we were thinking we could just add and use version=x to the Bootstrap xml. However the more I think about this it's arguably a bit more complicated than that because there are potentially so many occurrences in each project. So if you edited an existing project and so it automatically became the latest version and showed the titles where they didn't show before you would have to go through every page and every section checking. Perhaps a separate optional property like show previously hidden/all titles would be a solution?

ronm123 commented 1 year ago

@ingedonke @FayCross obviously my previous reply here was about https://github.com/thexerteproject/xerteonlinetoolkits/issues/1024 whereas it's the opposite problem reported by Inge here but related and part of any solution we put in place.

FayCross commented 1 year ago

Just done some testing to work out exactly what the happens now (some of this is already detailed in #1024). This problem is only with accordion & carousel navigators:

FayCross commented 1 year ago

@ingedonke @ronm123 closing this & #1024 but I can reopen after dev meeting later if you don't think the way I've done it is good enough!

Show titles on existing content on accordion & carousel navigators will continue working in same way but show titles on any new content added to those navigators will work correctly. This is so that old projects don't suddenly start hiding / showing titles unexpectedly.