search

thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Standalone page (in lightbox) not being tracked #1179

Closed torinfo closed 1 year ago

torinfo commented 1 year ago

Standalone pages are not tracked and/or shown in the results page

This is caused by the fact that they are generally started as a new session in a lightbox and there is (at the moment) no relation with the page where we started from.

torinfo commented 1 year ago

I fixed this for a standalone page from the same LO that is shown in a lightbox.

It required some extra code to detect this sitaution, and than piggy back on the tracking state of the parent object.

FayCross commented 1 year ago

@torinfo is this in master? Might be worth adding to release notes

torinfo commented 1 year ago

Fixed in bb2a214171b3beec25be4ee9f664b8c1635ccb62

torinfo commented 1 year ago

@FayCross No, this is only in 3.12, and yes good idea to add to release notes. This also effected the results page in non-tracking situations

FayCross commented 1 year ago

I've added this to English release notes (@ingedonke - you might want to copy this to Dutch release notes)

ingedonke commented 1 year ago

Hi Fay,

I tried to add it but John was editting the release notes. So I send him a question to close it. I asume it's closed now?

I'll take a look :)

Bye, Inge

FayCross @.***> schreef op 17 februari 2023 11:53:53 CET:

I've added this to English release notes @.*** - you might want to copy this to Dutch release notes)

-- Reply to this email directly or view it on GitHub: https://github.com/thexerteproject/xerteonlinetoolkits/issues/1179#issuecomment-1434468576 You are receiving this because you were mentioned.

Message ID: @.***>