thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Graphics and Sound page: Transcript Position Optional Property #1205

Closed JMarco27 closed 1 year ago

JMarco27 commented 1 year ago

If you select Below audio player, a Transcript button is displayed below the audio player bar. If you select Lightbox, a Transcript icon is displayed within the audio player bar. Do we need two different ways to access a transcript - can we just have the icon in the audio player bar?

FayCross commented 1 year ago

@JMarco27 There are two options in this case so that we don't change the way that older projects may have been set up. Before 3.12, graphics & sound page was the only page where you could add a transcript to accompany an audio player - the button for this was under the player. In 3.12 I've added transcript to all pages where you can upload audio - these transcript buttons will appear on the audio bar as there's not always another obvious place that we can put it (e.g. on narration audio players we couldn't add a transcript button below the player as it's already at bottom). I thought it was odd if graphics and sound page was the only place where the transcript button was in a different place so I've added the option to choose it's position. Generally we try not to change the appearance of existing projects with new releases so I couldn't just change the code to force the transcript button to always be on audio player bar even if it had been below previously.

FayCross commented 1 year ago

@JMarco27 I'm closing this but I have changed the default position of the transcript button on the graphics & sound page to be on the audio bar (rather than below). This brings it in line with position of button on other pages but means existing projects won't be changed automatically & there is a way for old projects with button below to be changed to have button on audio bar instead.