thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Disable Theme URL (XOT Project-level Optional Property) #1229

Closed JMarco27 closed 1 year ago

JMarco27 commented 1 year ago

There has been some discussion on the Xerte Doc group about this OP. We don't really understand what it does. Is it really needed and could it be deprecated?

image

ronm123 commented 1 year ago

Hi Jonathan no this can't be deprecated and is desirable because some organisations with custom or branded themes want to prevent the use of theme change via url whereas others who give more importance to accessibility would prioritise the user being able to change to their preference. So an example and demo via our Bootstrap demonstrator:

Bootstrap demonstrator with theme set by author https://xot.xerte.org.uk/play_137#page1 Changing the theme for the same project via url to a high contrast alternative https://xot.xerte.org.uk/play_137?&theme=blackgrey#page1 With the Disable Theme URL option added the second link wouldn't change the theme and as I say some organisations/authors want that and might send a custom link to one or more learners according to their preferences or provide a list of options for the learners to choose for themselves. The same functionality works for XOT projects too e.g. default page types demo: https://xot.xerte.org.uk/play_116#xertepagetypes theme changed to black on yellow https://xot.xerte.org.uk/play_116?theme=blackonyellow#xertepagetypes Each time you change a theme in a project the summary shows the url parameter for that theme.

ronm123 commented 1 year ago

Looks like github is removing the ? for some reason e.g. the second link above should be https://xot.xerte.org.uk/play_137?&theme=blackgrey#page1

ronm123 commented 1 year ago

I edited the 1st reply and corrected the second link.