thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Issue with LTI1.3 url when learner id mode set to group #1278

Closed ronm123 closed 4 months ago

ronm123 commented 4 months ago

I had it reported that Xerte wasn't working when using xAPI and LTI 1.3 links with the learner id mode was set to group. e.g. viewing the link from the LMS resulted in a blank screen.

It seems this is because the link provided in the properties window contains the required &group=groupname for the LTI 1.1 link but not have that appended for the LTI 1.3 link.

I'll commit a fix for this but @torinfo please check it's correct when you have a moment.

ronm123 commented 4 months ago

Fixed with https://github.com/thexerteproject/xerteonlinetoolkits/commit/60fe2053a53790c8ff2ba54b85250a0e2f5c9220