search

thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
63 stars 61 forks source link

email issues with different notifications #1342

Open ronm123 opened 1 month ago

ronm123 commented 1 month ago

because of my recent email issues I've noticed some issues with email from Xerte via peer review and also separately the lockfile functionality. It's possible some of this is old but worth discussion/clarity...

With peer review I've noticed that the default message and/or a typed message comes through as plain text so shows html like <b and <a etc e.g. Hello, <br><br> You've received feedback on your project: peer review test.<br><br><br><a href='https://xerteinstalladdress/peer.php?template_id=3046'>https://xerteinstalladdress/peer.php?template_id=3046</a><br><br><br>You have been asked to provide some feedback on this learning object created on the Xerte installation... I'm sure we had this working as rendered html at some point so what changed? Or does this depend on settings outside of Xerte?

I discovered some failed lockfile notifications and the failure is because it tries to send to username@xerteinstalladdress which often isn't a valid email address. I'm not sure if we have an option to control whether lockfile notifications are triggered or not but I think we should have if we don't? But also perhaps somewhere users can add their email to their login details so that notifications do work or change whatever is configured automatically. I guess this is a bit nuanced depending on the installation and users and email format and authentication method etc but does seem to need more control at the very least?

@torinfo @FayCross have you had issues with this and any thoughts on changes needed?

FayCross commented 1 month ago

@ronm123 UoN 3.12 install peer review emails are sending as HTML. Just tried testing on xotbeta but haven't had an email through. Lockfile emails are also working here but I guess that's just because username@xerteinstalladdress will always be a valid email address in our case. Seems like a good idea to have a management option to control the emails if this isn't always going to be the case

ronm123 commented 1 month ago

@FayCross thanks sounds like maybe it's a setting outside of Xerte impacting the email format - I'll do some more testing. Yes I think there's probably a simple option like send or don't send lockfile messages via email but ideally (perhaps longer term) we need to add an option for logged in users to add/set their preferred email and again enable/disable that via management too.