search

thexerteproject / xerteonlinetoolkits

Xerte Online Toolkits
www.xerte.org.uk
Apache License 2.0
62 stars 61 forks source link

Flash after 2020 #969

Closed FayCross closed 2 years ago

FayCross commented 4 years ago

Changes that need to be made in preparation for Flash end of life:

FayCross commented 3 years ago

I've just added an extra point above about the RSS template that's no longer useful. We could do with talking about all of this at next dev day.

FayCross commented 3 years ago

@torinfo Can the RSS feed template be made inactive as part of v3.10 upgrade? I guess there would have to be something in upgrade.php that makes this change directly in the database (if active anyway - at UoN I've already disabled it manually)

torinfo commented 3 years ago

@FayCross Will do (in upgrade.php)

JohnSmith-LT commented 2 years ago

Hi @torinfo just identifying some issues to work on and came across this...

How easy is it to disable this in the Workspace so that no more can be created, since it's flash only now? Seems this is the only remaining part of this issue so it can be removed.

I'm happy to take it on if you perhaps describe what needs doing - i.e. can it all be done with just an upgrade.php entry?

FayCross commented 2 years ago

It's just a field in the database that needs changing (originaltemplatesdetails > active) so just through upgrade.php I think. I turned it off at UoN by manually changing that field

JohnSmith-LT commented 2 years ago

Ok, thanks @FayCross, there's at least 1x other open issue linked to this so I think we should just go for it since it hasn't worked properly for a while anyway and now doesn't do anything because of Flash - will hold off to see if @torinfo agrees

torinfo commented 2 years ago

@JohnSmith-LT @FayCross I should have done this prior to releaseing 3.10.

This is indeed making the template inactive in upgrade.php. I would do that in the function _do_cleanup. This woiuld be the rist db change in that function. I can do that if you want. @JohnSmith-LT What is the related issue?

JohnSmith-LT commented 2 years ago

@torinfo if it's easier for you to do it then yes, please do - I'll probably mess it up!

The other issue was this https://github.com/thexerteproject/xerteonlinetoolkits/issues/296 but I've closed it now.

JohnSmith-LT commented 2 years ago

@torinfo I've implemented this now, as you said, in _do_cleanup rather than as a database upgrade.

Have tested several times and all seems to work for me but please cast an eye over when you get a spare moment to make sure that I haven't messed up somewhere and close if you are happy :-)

FayCross commented 2 years ago

I've just upgraded my xampp and it's removed the option of creating new RSS projects. I haven't tried a brand new install though - I guess it's also turned off by default in those?

JohnSmith-LT commented 2 years ago

Hmm, I'm not sure @FayCross, @torinfo is a change to upgrade.php enough for new installs also - i.e is upgrade.php run after new install or is there somewhere else that would need changed in order to fix this in a new install?

ronm123 commented 2 years ago

@FayCross @JohnSmith-LT @torinfo wasn't this discussed previously and because that template required flash it was disabled/hidden?

torinfo commented 2 years ago

@JohnSmith-LT @FayCross No, only upgrade.php is not good enough. There is a setup/basic.sql that inserts a few templates in the database, and that needs changing as well.

I can do that for you if you want.

JohnSmith-LT commented 2 years ago

Thanks @torinfo. I've changed the entry in line 90 of setup/basic.sql to:

(8,'xerte','Rss','Rss','Easily create and maintain an RSS Feed.','2008-04-02','RSS Feed',0,'*',0)

The 0 on the very end seems to be the 'active' flag.

I've committed the change so if you just confirm that I've not messed up ;-) then we should be good to close this one!