search

theyakka / qr.flutter

QR.Flutter is a Flutter library for simple and fast QR code rendering via a Widget or custom painter.
https://pub.dev/packages/qr_flutter
BSD 3-Clause "New" or "Revised" License
716 stars 320 forks source link

Implemented some interesting user suggestions #202

Closed alexanderkind closed 4 months ago

alexanderkind commented 1 year ago

Implemented some interesting user suggestions: 1) Rounding data module and eye corners #192 2) Rounding data module outside corners 3) Background shape behind embedded image with rounding corners (EmbeddedImageShape) 4) Adjusting the cutout of an embedded image #190 5) Gradient for all (QrDataModuleShape, QrEyeShape, EmbeddedImageShape) #143

vanyasem commented 1 year ago

thank you for addressing the review so quickly!

razfazz commented 1 year ago

wow very nice! thank you

mminhlequang commented 1 year ago

up

2Math0 commented 12 months ago

up

benjdero commented 9 months ago

@vanyasem What's preventing this from being merged? The proper image cutout alone makes the result look much more professional.

vanyasem commented 9 months ago

@benjdero the fact that I am just a contributor, and not a project maintainer. I do not have write access to this repository, and thus I cannot merge this PR :) You need to contact the maintainers of this repo by email: hello@theyakka.com

martipello commented 9 months ago

LGTM!!!

Hilbert2048 commented 5 months ago

@vanyasem why this update is still not merged?

vanyasem commented 5 months ago

@Hilbert2048 because I am just a random contributor, and not a maintainer of this project. I do not have write access to this repository, and thus I cannot merge this PR :) You need to contact the actual maintainers of this repo by email: hello@theyakka.com

Hilbert2048 commented 5 months ago

I think @lukef might have the write permission, would you please have a look at this pull request?