search

theypsilon / MiSTer_BIOS_SCRIPTS

Don't use this repository, go to Bios DB
16 stars 3 forks source link

URL for internet archive is incorrect #13

Closed nightkill9988 closed 3 years ago

nightkill9988 commented 3 years ago

The URL for the BIOS files is incorrect. current example in script is: '.../download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/NeoGeo.zip'

this should be updated to: '.../download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/MiSTer_Console_BIOS_PACK/NeoGeo.zip'

It appears that MiSTer_Console_BIOS_PACK.zip was updated on 3/29/2021 which might have lead to this change

MAME-GETTER commented 3 years ago

This has already been fixed. Remove the current bio and rerun the the BIOS-GETTER or update_all.sh

On Wed, Mar 31, 2021, 1:19 PM nightkill9988 @.***> wrote:

The URL for the BIOS files is incorrect. current example in script is:

'.../download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/NeoGeo.zip'

this should be updated to:

'.../download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/MiSTer_Console_BIOS_PACK/NeoGeo.zip'

It appears that MiSTer_Console_BIOS_PACK.zip was updated on 3/29/2021 which might have lead to this change

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKJU6IFCYHQGXKRXTUP6ALTGNKTXANCNFSM42FD4T2A .

nightkill9988 commented 3 years ago

This is a new build of mister and the first time running update_all or BIOS-GETTER. The error received for all BIOS downloads is:

STARTING BIOS RETRIVAL FOR: Astrocade

Downloading https://archive.org/download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/Astrocade.zip Archive: /media/fat/BIOS/Astrocade.zip

End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. note: /media/fat/BIOS/Astrocade.zip may be a plain executable, not an archive unzip: cannot find zipfile directory in one of /media/fat/BIOS/Astrocade.zip or /media/fat/BIOS/Astrocade.zip.zip, and cannot find /media/fat/BIOS/Astrocade.zip.ZIP, period. cp: cannot stat '/media/fat/BIOS/Astrocade/Bally Professional Arcade, Astrocade '\''3159'\'' BIOS (1978)(Bally Mfg. Corp.).bin': No such file or directory

Just tested again on a clean SD card with update_all.sh and received the same error. Going directly to the URL on a desktop results in a 0kb file download. The actual URL path for the BIOS in this message is: https://archive.org/download/mi-ster-console-bios-pack/MiSTer_Console_BIOS_PACK.zip/MiSTer_Console_BIOS_PACK/Astrocade.zip

MAME-GETTER commented 3 years ago

I have updated the the BIOS pack let me know if that fixes your issues.

MAME-GETTER commented 3 years ago

testing

nightkill9988 commented 3 years ago

Tested and it works. Thank you for repacking the BOIS pack.

MAME-GETTER commented 3 years ago

@nightkill9988 Thank you for reporting and taking time explain the issue. The incorrect packing was an oversight. Its users like you who help make these scripts great.