search

theypsilon / MiSTer_BIOS_SCRIPTS

Don't use this repository, go to Bios DB
16 stars 3 forks source link

BIOS updater script does not copy all NeoGeo ROM files into correct final locations #20

Closed c0d3h4x0r closed 2 years ago

c0d3h4x0r commented 2 years ago

The BIOS updater script neglects to perform the following copy operations after downloading the files:

theypsilon commented 2 years ago

Sounds like a good suggestion, now that selecting between bios is possible in the core. I'll do some tests. Thanks for opening the issue!

c0d3h4x0r commented 2 years ago

Aren't those ROM files needed by UniBIOS regardless?

Sent via Outlook for iOShttps://aka.ms/o0ukef

From: José Manuel Barroso Galindo @.> Sent: Saturday, December 4, 2021 4:03:59 PM To: theypsilon/MiSTer_BIOS_SCRIPTS @.> Cc: Keith F. Kelly @.>; Author @.> Subject: Re: [theypsilon/MiSTer_BIOS_SCRIPTS] BIOS updater script does not copy all NeoGeo ROM files into correct final locations (Issue #20)

Sounds like a good suggestion, now that selecting between bios is possible in the core. I'll do some tests. Thanks for opening the issue!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftheypsilon%2FMiSTer_BIOS_SCRIPTS%2Fissues%2F20%23issuecomment-986138647&data=04%7C01%7C%7C635ffa2e5b81477b840f08d9b782bd04%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637742594404333967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=lNSPdzo1d%2FcARvk%2B7eTEkjJMTejB3tXuKe22d%2BiwQNg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF2EYJFSBXX6CK7GHSQVFK3UPKT67ANCNFSM5JLCKXLA&data=04%7C01%7C%7C635ffa2e5b81477b840f08d9b782bd04%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637742594404333967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kcuhFLTD5UnSUoTk68T1KAsbAcJIPaIRGsq39h04B%2BM%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C635ffa2e5b81477b840f08d9b782bd04%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637742594404333967%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fh5DKYvUF9TWYt3WhtVFwfX7qOTSpZsgFRp5TOA4W14%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C635ffa2e5b81477b840f08d9b782bd04%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637742594404490731%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bmYCOh5E%2BbBWFjy6%2Fgd413S5yydoY%2FU6B%2B449AwfKxA%3D&reserved=0.

theypsilon commented 2 years ago

They weren't needed. I've just implemented your suggestion and now it copies all 5 bioses. Thanks again!