search

theypsilon / MiSTer_BIOS_SCRIPTS

Don't use this repository, go to Bios DB
16 stars 3 forks source link

More compact code #5

Closed frederic-mahe closed 4 years ago

frederic-mahe commented 4 years ago

This is merely a suggestion. No need to write the downloaded script to mass storage, you can execute it directly.

theypsilon commented 4 years ago

Just one little thing to point out. /tmp is not mass storage in MiSTer, as it is mounted in RAM. Piping a script into bash works, but messes with the ${0} and other variables, that's why I consider it a less ideal solution than calling the script normally.

frederic-mahe commented 4 years ago

I see, thanks for the info. Then, what about skipping the chmod +x bios-getter.sh and executing the file directly (bash bios-getter.sh)? That should not alter ${0}.

Again, these are merely suggestions, I hope I am not annoying you, I just really like to review code, that's all.

theypsilon commented 4 years ago

No is actually the opposite, I think your suggestions are very valuable. I hope to keep seeing you around. I've tested these changes and they are good to merge.

frederic-mahe commented 4 years ago

thanks!

MAME-GETTER commented 4 years ago

@frederic-mahe your suggestions are very welcomed, Thankyou! All of your retro gaming github projects are legendary. love the SM Rompacks and NT Jailbreaks you host.