contains_str function could be replaced with grep -q

theypsilon / Update_All_MiSTer

All-in-one script for updating your MiSTer

GNU General Public License v3.0

629 stars 27 forks source link

Closed frederic-mahe closed 4 years ago

frederic-mahe commented 4 years ago

Shorter code, one less function.

In fact the whole test can be factorized:

if grep -oq ".mra" /media/fat/Scripts/.mister_updater{,_jt,_unofficials}/update_all.log ; then
...

theypsilon commented 4 years ago

Thanks for the changes.

It looks good @frederic-mahe, could you please add that one-liner there instead?

Also in the lines 245-247.

I will test after your changes are ready and if all is fine, it will get merged.

frederic-mahe commented 4 years ago

I've created a new pull request to include your recent changes (see https://github.com/theypsilon/Update_All_MiSTer/pull/3).