search

theypsilon / Update_All_MiSTer

All-in-one script for updating your MiSTer
GNU General Public License v3.0
664 stars 28 forks source link

Jotego Updater does not download beta cores or MRA, even though "Install Beta Cores" is true #57

Closed polyh3dron closed 3 years ago

polyh3dron commented 3 years ago

Install Beta Cores is set to "true". A full resync has been forced. The INI file has been cleared/deleted, and settings re-entered. Clear All Cores option in update_all has been used so all cores and MRAs were deleted before the most recent attempt. The Jotego Updater is still only downloading public cores and MRAs for me. No beta cores or MRAs.

theypsilon commented 3 years ago

Are you running update_all from ssh and staying on /root ? In that case you would have to go first to /media/fat/Scripts Will handle this better in the future: https://github.com/theypsilon/Update_All_MiSTer/issues/56

sigboe commented 3 years ago

@theypsilon Cant you just do this in the beginning of the updater

scriptdir="$(dirname "$(readlink -f "${0}")")"
pushd "${scriptdir}"

(also maybe for cleanliness sake add popd to the end of the script or exit routine)

or use scriptdir="$(dirname "$(readlink -f "${0}")")" and refrence ini files as "${scriptdir}/file.ini" ?

theypsilon commented 3 years ago

@theypsilon Cant you just do this in the beginning of the updater

scriptdir="$(dirname "$(readlink -f "${0}")")"
pushd "${scriptdir}"

(also maybe for cleanliness sake add popd to the end of the script or exit routine)

or use scriptdir="$(dirname "$(readlink -f "${0}")")" and refrence ini files as "${scriptdir}/file.ini" ?

Yes, something like this is planned to be added. Is not as straight forward because there is something in place doing that already, and it shouldn't conflict.

sigboe commented 3 years ago

pushd works like a stack, so it should not interfere?

theypsilon commented 3 years ago

pushd works like a stack, so it should not interfere?

I know, I use pushd in most of my scripts, including this one. But path resolution is not trivial in some places, and the changes have to be thoroughly tested before releasing an update.

sigboe commented 3 years ago

Good on you for testing thoroughly. Just want to say I have had great success in using scriptdir="$(dirname "$(readlink -f "${0}")")" to determin the location of my scripts. Even with symlinks

polyh3dron commented 3 years ago

Are you running update_all from ssh and staying on /root ? In that case you would have to go first to /media/fat/Scripts Will handle this better in the future: #56

Yes, I am running this from SSH and staying in /root. I run all of my MiSTer scripts this way since I can’t see the frame buffer terminal from my CRT.

A pretty normal use case, no?

theypsilon commented 3 years ago

This should be working now as discussed here.

polyh3dron commented 3 years ago

Thanks!