theyworkforyou / shineyoureye-sinatra

Parliamentary monitoring site for Nigeria
https://www.shineyoureye.org/
4 stars 3 forks source link

Add some code quality checker / code metrics #41

Open octopusinvitro opened 7 years ago

octopusinvitro commented 7 years ago

I think our classes are pretty straight-forward and I've been trying to escape conditionals with duck typing etc. etc. but we might get a surprise here.

There are many static analysers out there but maybe something like CodeClimate or something that gives us a flog score.

mhl commented 7 years ago

RuboCop does some useful code complexity checks already, since I had to simplify the hacky bin/build_summaries.rb script to get them to pass :) e.g. it includes:

It might be interesting to have addition checks, though.

mhl commented 7 years ago

Timebox to 1 day