search

thezbyg / gpick

Advanced color picker written in C++ using GTK+ toolkit
BSD 3-Clause "New" or "Revised" License
376 stars 33 forks source link

Wrong folder name when building #187

Open luyatshimbalanga opened 3 years ago

luyatshimbalanga commented 3 years ago

The current tarball 0.2.6 contains the folder named "gpick-gpick-0.2.6" instead of "gpick-0.2.6" which suggests a typing error. As a result, the build will fail.

thezbyg commented 3 years ago

Release and tag tarballs are generated automatically by GitHub. I think that the name of archive file and top folder is a concatenation of project name and commit reference. Release tags are named with gpick- prefix, so final names include double prefixes and this is not a typo. As far as I understand, the only way to change this is to rename tags in repository.

Folder name should not have any influence on the build process. I just tested your linked tarball with both CMake and SCons build systems, and it builds without issues. Could you explain in more detail how your build fails?

luyatshimbalanga commented 3 years ago

Prior to 0.2.6rc1, the previous tarball lacked extra prefix as highlighted by this diff as testing on Fedora build where %name is "gpick". Although the fix was simple, it will be great to prevent such minor issue for future packagers.

ryandesign commented 1 year ago

I think this can be closed as completed. As was said above, GitHub decides what folder name to use for automatically-generated tarballs. To avoid this and other problems inherent in automatically-generated tarballs, projects should manually generate tarballs and upload them to each GitHub release. It looks like the gpick project once again manually generates and uploads tarballs as of version 0.3. It previously did so on Google Code for versions 0.2.5 and earlier. Only version 0.2.6 did not get a manually-created tarball.